search

JuliaImages / ExifViewer.jl

Metadata reader in Julia, wrapper over LibExif
https://juliaimages.org/ExifViewer.jl/dev/
MIT License
28 stars 1 forks source link

Adds GPS tags support and upgrades to higher libexif_jll version with ARM MacOS support #18

Closed ashwani-rathee closed 1 year ago

ashwani-rathee commented 1 year ago

For:

Fixes #17( for ARM MacOS support) #11 (for GPS tag support), major issue is in consistency of generator, I don't want such big changes in LibExif.jl every commit

codecov[bot] commented 1 year ago

Codecov Report

Base: 92.94% // Head: 92.45% // Decreases project coverage by -0.50% :warning:

Coverage data is based on head (9283ae7) compared to base (e1254f2). Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #18 +/- ## ========================================== - Coverage 92.94% 92.45% -0.50% ========================================== Files 4 4 Lines 156 159 +3 ========================================== + Hits 145 147 +2 - Misses 11 12 +1 ``` | [Impacted Files](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/read.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3JlYWQuamw=) | `94.20% <83.33%> (-1.26%)` | :arrow_down: | | [src/utils.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/18?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3V0aWxzLmps) | `69.23% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ashwani-rathee commented 1 year ago

Problem was that some tags have same value based on which they get assigned their tag and hence can't be used in @enum ExifTag(unique value only in enum) so some GPS tags are left out and kept out marked as const.

To incorporate those for to be read when reading GPS IFD, what I did is made another enum ExifTagGPS which holds GPS tags. When I read the tags and if it is GPS IFD, I check if that number for identification of tags exists in ExifTagGPS or not..if it does I update it with Tag from ExifTagGPS. I don't consider support in GPS IFD and prioritize GPS tags. Also I kept changes to minimum in the generated file, hoping it stays similar next time too whenever I have to generate it next. Closes #17 and #11