Closed ashwani-rathee closed 1 year ago
Base: 92.94% // Head: 92.45% // Decreases project coverage by -0.50%
:warning:
Coverage data is based on head (
9283ae7
) compared to base (e1254f2
). Patch coverage: 87.50% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Problem was that some tags have same value based on which they get assigned their tag and hence can't be used in @enum ExifTag(unique value only in enum) so some GPS tags are left out and kept out marked as const.
To incorporate those for to be read when reading GPS IFD, what I did is made another enum ExifTagGPS which holds GPS tags. When I read the tags and if it is GPS IFD, I check if that number for identification of tags exists in ExifTagGPS or not..if it does I update it with Tag from ExifTagGPS. I don't consider support in GPS IFD and prioritize GPS tags. Also I kept changes to minimum in the generated file, hoping it stays similar next time too whenever I have to generate it next. Closes #17 and #11
For:
Fixes #17( for ARM MacOS support) #11 (for GPS tag support), major issue is in consistency of generator, I don't want such big changes in LibExif.jl every commit