JuliaImages / ExifViewer.jl

Metadata reader in Julia, wrapper over LibExif
https://juliaimages.org/ExifViewer.jl/dev/
MIT License
28 stars 1 forks source link

Extending encode operation to handle all formats #21

Closed ashwani-rathee closed 1 year ago

ashwani-rathee commented 1 year ago

Supposed to improve encode operation and extend support

Note:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.72% and project coverage change: -2.85 :warning:

Comparison is base (2f793a2) 93.06% compared to head (403d972) 90.21%.

:exclamation: Current head 403d972 differs from pull request most recent head a7c5b44. Consider uploading reports for the commit a7c5b44 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #21 +/- ## ========================================== - Coverage 93.06% 90.21% -2.85% ========================================== Files 5 5 Lines 173 184 +11 ========================================== + Hits 161 166 +5 - Misses 12 18 +6 ``` | [Impacted Files](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/utils.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3V0aWxzLmps) | `55.55% <ø> (-13.68%)` | :arrow_down: | | [src/write.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3dyaXRlLmps) | `88.88% <80.55%> (-5.85%)` | :arrow_down: | | [src/precompile.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `100.00% <100.00%> (ø)` | | | [src/read.jl](https://codecov.io/gh/JuliaImages/ExifViewer.jl/pull/21?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3JlYWQuamw=) | `94.28% <100.00%> (+0.08%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ashwani-rathee commented 1 year ago

Now encoding is more generalized but the support is still limited(part of future scope of work). I'll close this in atm to move forward, also encoding seems to fails in x86 system for some reason but I don't have x86 system atm so leaving the support out atm.