JuliaImages / ExifViewer.jl

Metadata reader in Julia, wrapper over LibExif
https://juliaimages.org/ExifViewer.jl/dev/
MIT License
28 stars 1 forks source link

using `splitext` instead of `split` #23

Closed t-bltg closed 1 year ago

t-bltg commented 1 year ago

One should use splitext instead of split, since using split fails if a . is present in the filename (e.g. hidden directory on linux):

julia> split("/foo/bar/.hidden/fig.jpg", ".")[2]
"hidden/fig"
julia> splitext("/foo/bar/.hidden/fig.jpg")[2]
".jpg"
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (403d972) 90.21% compared to head (476fb7a) 90.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #23 +/- ## ======================================= Coverage 90.21% 90.21% ======================================= Files 5 5 Lines 184 184 ======================================= Hits 166 166 Misses 18 18 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaImages/ExifViewer.jl/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/utils.jl](https://app.codecov.io/gh/JuliaImages/ExifViewer.jl/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3V0aWxzLmps) | `55.55% <ø> (ø)` | | | [src/write.jl](https://app.codecov.io/gh/JuliaImages/ExifViewer.jl/pull/23?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3dyaXRlLmps) | `88.88% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

ashwani-rathee commented 1 year ago

@t-bltg thanks for your first contribution to ExifViewer.jl and first ever contribution to any of my packages actually!!

Writing tags needs a lot more work, let's merge this!