search

JuliaImages / ImageBinarization.jl

A Julia package of algorithms for analyzing images and automatically binarizing them into background and foreground.
MIT License
35 stars 8 forks source link

refactor Balanced using the functor API #32

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

This is a PR-commit for PR https://github.com/zygmuntszpak/ImageBinarization.jl/pull/29 that refactors the whole codebase to use the new functor API, which is discussed in more details in https://github.com/zygmuntszpak/ImageBinarization.jl/issues/26 and explained in my GSoC 2019 blog

Changes:

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (api@2951a80). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##             api      #32   +/-   ##
======================================
  Coverage       ?   41.27%           
======================================
  Files          ?       20           
  Lines          ?      172           
  Branches       ?        0           
======================================
  Hits           ?       71           
  Misses         ?      101           
  Partials       ?        0
Impacted Files Coverage Δ
src/balanced.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2951a80...36c8f13. Read the comment docs.

johnnychen94 commented 5 years ago

@zygmuntszpak the test passed so we can safely merge them.

All the following PRs are created in this pattern so that you can review them easily. For non-trivial cases that worth attention, I'll add a comment to them like in this PR.

There can be some further changes on the codebase, but at least for now, I'd like to keep changes relatively small in these sequences of PRs which simply wrap the implementations in the functor.