JuliaImages / ImageBinarization.jl

A Julia package of algorithms for analyzing images and automatically binarizing them into background and foreground.

MIT License

35 stars 8 forks source link

refactor Otsu using the functor API #38

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

This is a PR-commit for PR https://github.com/zygmuntszpak/ImageBinarization.jl/pull/29 that refactors the whole codebase to use the new functor API, which is discussed in more details in https://github.com/zygmuntszpak/ImageBinarization.jl/issues/26 and explained in my GSoC 2019 blog

Changes:

support Color3 input
move implementations into functor
enhance the test codes with wider test coverage

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into api will increase coverage by 3.85%. The diff coverage is 100%.

@@            Coverage Diff             @@
##              api      #38      +/-   ##
==========================================
+ Coverage   37.42%   41.27%   +3.85%     
==========================================
  Files          20       20              
  Lines         171      172       +1     
==========================================
+ Hits           64       71       +7     
+ Misses        107      101       -6

Impacted Files	Coverage Δ
src/otsu.jl	`100% <100%> (+100%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95184f6...675077c. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #38 into api will increase coverage by 3.85%. The diff coverage is 100%.

@@            Coverage Diff             @@
##              api      #38      +/-   ##
==========================================
+ Coverage   37.42%   41.27%   +3.85%     
==========================================
  Files          20       20              
  Lines         171      172       +1     
==========================================
+ Hits           64       71       +7     
+ Misses        107      101       -6

Impacted Files	Coverage Δ
src/otsu.jl	`100% <100%> (+100%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95184f6...675077c. Read the comment docs.