JuliaImages / ImageContrastAdjustment.jl

A Julia package for enhancing and manipulating image contrast.
MIT License
11 stars 5 forks source link

Bring docs stage back in travis CI #30

Closed johnnychen94 closed 4 years ago

johnnychen94 commented 4 years ago

Travis seems to not understand the configuration and missed the docs stage. (e.g., https://travis-ci.org/github/JuliaImages/ImageContrastAdjustment.jl/builds/667514858)

I'm not sure if this fixes the problem, so there might be many commits here.

Looks like the docs in ImageBinarization aren't updated as well...

codecov[bot] commented 4 years ago

Codecov Report

Merging #30 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #30   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          14       14           
  Lines         491      491           
=======================================
  Hits          471      471           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0cfa120...44c9d65. Read the comment docs.

timholy commented 4 years ago

Would 1.1 work better than 1.1.0, by any chance?

johnnychen94 commented 4 years ago

No idea why it's broken, perhaps the Travis syntax is changed given that nobody is touching the configuration file these days.

My best guess is that the matrix expanding somehow overwrites the include section. I've recently found two similar issues: https://github.com/JuliaImages/ImageCore.jl/commit/73a2f1b208bacb0348645a3c1ac1727cd8dd1968 and https://github.com/FluxML/Flux.jl/pull/1066

Update: Commenting out matrix part works. Although it's not displayed here, the Travis CI is actually running: https://travis-ci.org/github/JuliaImages/ImageContrastAdjustment.jl/builds/669283091

johnnychen94 commented 4 years ago

Looks like mixing jobs and matrix is problematic and makes travis only read the first occurrence, which was matrix, and thus jobs part is ignored.