search

JuliaImages / ImageCore.jl

Julia types for representing images
Other
28 stars 20 forks source link

Drop Julia 1.0, alphabetize [compat] #194

Closed timholy closed 1 year ago

timholy commented 1 year ago

Makes Aqua happy

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -4.23 :warning:

Comparison is base (0046ec7) 75.50% compared to head (55d6d5c) 71.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #194 +/- ## ========================================== - Coverage 75.50% 71.28% -4.23% ========================================== Files 10 10 Lines 592 592 ========================================== - Hits 447 422 -25 - Misses 145 170 +25 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaImages/ImageCore.jl/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/precompile.jl](https://app.codecov.io/gh/JuliaImages/ImageCore.jl/pull/194?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `94.18% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/JuliaImages/ImageCore.jl/pull/194/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timholy commented 1 year ago

OK, it's worse than I thought. This is only about tests, but it can't even install the test dependencies on Julia 1.0.

I really regret not making Julia 1.6 the minimum for this release. Let's see if General allows us to register 0.10.1 while dropping Julia 1.0 support.

timholy commented 1 year ago

What do you know...it's accepting it. Somehow I thought we had to bump the minor version when dropping support for older Julia versions, but maybe that applies only post-1.x packages (for which a minor bump is not breaking).