Algorithms from Images.jl to form base

[ashwani-rathee]

• Part of restructuring effort to get corner related algorithms outside of Images.jl and hence ensuring that when accessing corner related algorithms, we don't have to install Images.jl directly which is a heavy dependency. This is needed for Pure Julia ProjectiveGeometry and Camera Calibration solutions. I intend to bring some more algorithms I saw in ImageProjectiveGeometry.jl

[codecov[bot]]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@67c5735). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1 +/- ## ========================================= Coverage ? 95.05% ========================================= Files ? 5 Lines ? 182 Branches ? 0 ========================================= Hits ? 173 Misses ? 9 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[timholy]

Splitting this out is a good idea. Is corner detection similar enough to edge-detection that combining this with https://github.com/JuliaImages/ImageEdgeDetection.jl makes sense? It seems extensive enough that it's also fine to leave it as a standalone function.

[ashwani-rathee]

We sure could combine ImageCorners.jl and ImageEdgeDetection.jl given only 3 corner detectors atm but when we bring in algorithms from ImageProjectiveGeometry.jl here: https://github.com/peterkovesi/ImageProjectiveGeometry.jl/blob/master/src/cornerfeatures.jl it will start to get bit cluttered. Also keeping these packages modular and small allows more breathing space for experimentation for model based methods that I want to work on. Could we say corner detection is a layer above edge detection? I do remember utilizing non-maxima suppression when writing checkboard detector that ImageEdgeDetection.jl provides: https://github.com/ashwani-rathee/CameraCalibrations.jl/blob/main/src/checkerboard.jl

[zygmuntszpak]

I recommend keeping ImageCorners separate from ImageEdgeDetection. The non-maxima suppression that is used in edge detection is somewhat different from the kind of non-maxima suppression that is often utilised by many corner detection algorithms.

[timholy]

Sounds good to me, thanks for tackling this @ashwani-rathee.

[ashwani-rathee]

Couple of questions:

• Any preferences on what colors/type of arrays we definitely want to precompile? I currently just pick what @timholy and @johnnychen94 use.
• Which of the methods in my precompile file are redundant/not needed?
• Why is it when I explicitly tell it to precompile, I don't see the @info string I mentioned in precompile.jl? Is it even precompiling again or I did something very wrong ;-;?

Also following this PR, We really need to get the benchmarks for these algorithms in image_benchmarks.