Open Jay-sanjay opened 1 year ago
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
5a06e25
) 95.08% compared to head (866a300
) 89.00%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ashwani-rathee , sir please do check if there are any issues with the algorithm
Also, you could run tests you wrote with:
julia> ] test
yeah sir here it is I have pushed the code with minor modifications.
sir is the error figured out.....
With some of my own changes:
res = moravec(ImageCorners.Gray.(testimage("chelsea"));window_size=3, drange = 1);save("test.jpg", res/maximum(res))
I do end up getting this which is close to what we need:
Fixes #5 I have added the Moravec corner detection algorithm to the corner-algorithms.jl file