JuliaImages / ImageCorners.jl

Corner Related Algorithms ⛶
https://juliaimages.org/ImageCorners.jl/dev/
MIT License
9 stars 1 forks source link

Implementing Moravec corner detection algorithm #15

Open Jay-sanjay opened 1 year ago

Jay-sanjay commented 1 year ago

Fixes #5 I have added the Moravec corner detection algorithm to the corner-algorithms.jl file

codecov[bot] commented 1 year ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5a06e25) 95.08% compared to head (866a300) 89.00%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #15 +/- ## ========================================== - Coverage 95.08% 89.00% -6.09% ========================================== Files 5 5 Lines 183 200 +17 ========================================== + Hits 174 178 +4 - Misses 9 22 +13 ``` | [Files](https://app.codecov.io/gh/JuliaImages/ImageCorners.jl/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/ImageCorners.jl](https://app.codecov.io/gh/JuliaImages/ImageCorners.jl/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL0ltYWdlQ29ybmVycy5qbA==) | `100.00% <ø> (ø)` | | | [src/cornerapi.jl](https://app.codecov.io/gh/JuliaImages/ImageCorners.jl/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL2Nvcm5lcmFwaS5qbA==) | `100.00% <ø> (ø)` | | | [src/corner-algorithms.jl](https://app.codecov.io/gh/JuliaImages/ImageCorners.jl/pull/15?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL2Nvcm5lci1hbGdvcml0aG1zLmps) | `77.55% <23.52%> (-11.34%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Jay-sanjay commented 1 year ago

@ashwani-rathee , sir please do check if there are any issues with the algorithm

ashwani-rathee commented 1 year ago

Also, you could run tests you wrote with:

julia> ] test
Jay-sanjay commented 1 year ago

yeah sir here it is I have pushed the code with minor modifications.

Jay-sanjay commented 1 year ago

sir is the error figured out.....

ashwani-rathee commented 1 year ago

With some of my own changes:

res = moravec(ImageCorners.Gray.(testimage("chelsea"));window_size=3, drange = 1);save("test.jpg", res/maximum(res))

I do end up getting this which is close to what we need: image