JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

Redesign the codebase #14

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

We don't need to create another Image* metric to implement the codes, multiple dispatches on AbstractArray{<:AbstractArray} is sufficient.

The current colwise function doesn't take much advantage of existing codes from Distances.jl, so I almost rewrite it following the same pattern in Distances.jl

TODO:

Won't do in this PR:

codecov[bot] commented 5 years ago

Codecov Report

Merging #14 into master will decrease coverage by 69.93%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage   97.46%   27.53%   -69.94%     
===========================================
  Files           4        4               
  Lines          79       69       -10     
===========================================
- Hits           77       19       -58     
- Misses          2       50       +48
Impacted Files Coverage Δ
src/ImageDistances.jl 100% <ø> (ø) :arrow_up:
src/generic.jl 100% <100%> (+4.34%) :arrow_up:
src/hausdorff.jl 0% <0%> (-100%) :arrow_down:
src/ciede2000.jl 0% <0%> (-75%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6bb1cf...7584cbd. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #14 into master will decrease coverage by 32.13%. The diff coverage is 79.62%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage    97.4%   65.26%   -32.14%     
===========================================
  Files           4        5        +1     
  Lines          77       95       +18     
===========================================
- Hits           75       62       -13     
- Misses          2       33       +31
Impacted Files Coverage Δ
src/metrics.jl 100% <100%> (ø)
src/ImageDistances.jl 50% <33.33%> (-50%) :arrow_down:
src/ciede2000.jl 71.42% <50%> (-3.58%) :arrow_down:
src/hausdorff.jl 37.2% <64.28%> (-62.8%) :arrow_down:
src/generic.jl 94.73% <93.33%> (-0.92%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 487fc44...98280aa. Read the comment docs.

johnnychen94 commented 5 years ago

@juliohm There's only one last TODO(CIEDE2000) for this PR to be ready, do you have time to have a look at recently? I believe a large part of the code is justified by the test cases.

johnnychen94 commented 5 years ago

I'd like to merge this PR ASAP so that I can do other enhancements based on this PR. @juliohm