search

JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

Crosstype distances stability #23

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

When there's no roundoff conversion errors (FixedPoint->Float), numerical accuracy stability is guaranteed for any possible combination of the following list:

codecov[bot] commented 5 years ago

Codecov Report

Merging #23 into master will increase coverage by 2.16%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   63.55%   65.71%   +2.16%     
==========================================
  Files           5        5              
  Lines         107      105       -2     
==========================================
+ Hits           68       69       +1     
+ Misses         39       36       -3
Impacted Files Coverage Δ
src/ImageDistances.jl 75% <0%> (+25%) :arrow_up:
src/ciede2000.jl 90% <100%> (ø) :arrow_up:
src/metrics.jl 62.5% <100%> (+6.94%) :arrow_up:
src/generic.jl 90% <50%> (+2.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8ea625...075a3c2. Read the comment docs.

johnnychen94 commented 5 years ago

Except for not throwing ArgumentError anymore for CIEDE2000 with 3d number array inputs, a large part of this PR is about test cases, so it's quite safe to merge.