Closed johnnychen94 closed 5 years ago
Not understanding the JuliaImage principles well, I accidentally restrict input image types to 2d images for some distances(e.g., Hausdorff) in https://github.com/JuliaImages/ImageDistances.jl/commit/f18c71cae983d4cac008094c4ef8732f2f5cbbfb
Hausdorff
Basic principle: Array elements are pixels. This means 3d number images are always assumed to be Gray3dImage.
Related discussions on this principle:
Related issue:
In #19 an ArgumentError will be thrown for CIEDE2000 distance with 3d Number image input, which is rolled back in #23 and is interpreted as Gray3dImage
fixed by #26
johnnychen94
commented
5 years ago
Not understanding the JuliaImage principles well, I accidentally restrict input image types to 2d images for some distances(e.g.,
Hausdorff) in https://github.com/JuliaImages/ImageDistances.jl/commit/f18c71cae983d4cac008094c4ef8732f2f5cbbfbBasic principle: Array elements are pixels. This means 3d number images are always assumed to be Gray3dImage.
Related discussions on this principle:
Related issue:
In #19 an ArgumentError will be thrown for CIEDE2000 distance with 3d Number image input, which is rolled back in #23 and is interpreted as Gray3dImage