JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

fix a deprecation and test on Julia 1.0 #3

Closed rdeits closed 6 years ago

rdeits commented 6 years ago

(also cleans up the Travis configuration file a bit)

codecov[bot] commented 6 years ago

Codecov Report

Merging #3 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #3   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          55     52    -3     
=====================================
- Hits           55     52    -3
Impacted Files Coverage Δ
src/hausdorff.jl 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3adc26e...0b0f90b. Read the comment docs.

juliohm commented 6 years ago

Thanks! Is the last line of .travis.yml redundant? Should we erase it as well? It seems like the previous line already calls Coverage.submit?

juliohm commented 6 years ago

I will merge, clean it up further, and tag a new release, thanks again for catching this.

rdeits commented 6 years ago

Ah, you're right. But actually it was the second-to-last line that should have been changed: I separated out the Codecov submission from the Coveralls submission into separate Travis commands in case one or the other fails, but I forgot to delete the extra Codecov submission.

juliohm commented 6 years ago

Got it, I will do the split and tag. I also removed the dependency on Statistics, by just rewriting sum(x) / length(x) instead of mean(x)