Closed johnnychen94 closed 5 years ago
Merging #30 into master will increase coverage by
3.39%
. The diff coverage is80.76%
.
@@ Coverage Diff @@
## master #30 +/- ##
=========================================
+ Coverage 65.71% 69.1% +3.39%
=========================================
Files 5 6 +1
Lines 105 123 +18
=========================================
+ Hits 69 85 +16
- Misses 36 38 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/ImageDistances.jl | 75% <ø> (ø) |
:arrow_up: |
src/metrics_distances.jl | 62.5% <62.5%> (ø) |
|
src/metrics.jl | 88.88% <88.88%> (+26.38%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8e24ae1...588e11b. Read the comment docs.
merge since there's no feedback.
I'll revisit the codebase before 0.3 release
This is part of the porting work https://github.com/JuliaImages/ImageDistances.jl/issues/17
sad
-->sad
SumAbsoluteDifference
ssd
-->ssd
SumSquaredDifference
sadn
-->mae
MeanAbsoluteDifference
ssdn
-->mse
MeanSquaredDifference
rmse
RootMeanSquaredDifference
There are two things I definitely need feedbacks:
sadn
andssdn
good to you?SumAbsoluteDifference
is equivalent toCityblock
,SumSquaredDifference
is equivalent toSqEucleadean
. Should I deprecate each one of them? (if yes, I prefer to deprecateCityblock
andSqEucleadean
)Note on
git diff
: The previousmetrics.jl
is renamed tometrics_distances.jl
, to indicates that they are metrics exported byDistances.jl