JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

add sad ssd mae mse rmse #30

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

This is part of the porting work https://github.com/JuliaImages/ImageDistances.jl/issues/17

There are two things I definitely need feedbacks:

Note on git diff: The previous metrics.jl is renamed to metrics_distances.jl, to indicates that they are metrics exported by Distances.jl

codecov[bot] commented 5 years ago

Codecov Report

Merging #30 into master will increase coverage by 3.39%. The diff coverage is 80.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #30      +/-   ##
=========================================
+ Coverage   65.71%   69.1%   +3.39%     
=========================================
  Files           5       6       +1     
  Lines         105     123      +18     
=========================================
+ Hits           69      85      +16     
- Misses         36      38       +2
Impacted Files Coverage Δ
src/ImageDistances.jl 75% <ø> (ø) :arrow_up:
src/metrics_distances.jl 62.5% <62.5%> (ø)
src/metrics.jl 88.88% <88.88%> (+26.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8e24ae1...588e11b. Read the comment docs.

johnnychen94 commented 5 years ago

merge since there's no feedback.

I'll revisit the codebase before 0.3 release