JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

ambiguity patches #33

Open johnnychen94 opened 5 years ago

johnnychen94 commented 5 years ago

Before this patch there're 32 ambiguities, of which:


Details of ❌ : it should be r::AbstractVector for these two methods in the upstream Distances.jl. cc: @nalimilan

julia> using ImageDistances, Distances, Test

julia> foreach(enumerate(detect_ambiguities(Distances, ImageDistances))) do (i, x)
              println("No.", i, ":")
              println("    ", x[1])
              println("    ", x[2])
              println()
       end
No.1:
    colwise!(r::AbstractArray, dist::SqMahalanobis{T}, a::AbstractArray{T,2} where T, b::AbstractArray{T,2} where T) where T<:Real in Distances at /Users/jc/.julia/packages/Distances/KqP84/src/mahalanobis.jl:29
    colwise!(r::AbstractArray{T,1} where T, dist::PreMetric, a::AbstractArray{#s15,2} where #s15<:(AbstractArray{T,N} where N where T<:Union{Number, ColorTypes.Colorant}), b::AbstractArray{#s14,2} where #s14<:(AbstractArray{T,N} where N where T<:Union{Number, ColorTypes.Colorant})) in ImageDistances at /Users/jc/Documents/Julia/ImageDistances.jl/src/generic.jl:17

No.2:
    colwise!(r::AbstractArray, dist::Mahalanobis{T}, a::AbstractArray{T,2} where T, b::AbstractArray{T,2} where T) where T<:Real in Distances at /Users/jc/.julia/packages/Distances/KqP84/src/mahalanobis.jl:93
    colwise!(r::AbstractArray{T,1} where T, dist::PreMetric, a::AbstractArray{#s15,2} where #s15<:(AbstractArray{T,N} where N where T<:Union{Number, ColorTypes.Colorant}), b::AbstractArray{#s14,2} where #s14<:(AbstractArray{T,N} where N where T<:Union{Number, ColorTypes.Colorant})) in ImageDistances at /Users/jc/Documents/Julia/ImageDistances.jl/src/generic.jl:17
codecov[bot] commented 5 years ago

Codecov Report

Merging #33 into master will decrease coverage by 7.77%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   87.61%   79.83%   -7.78%     
==========================================
  Files           6        6              
  Lines         113      124      +11     
==========================================
  Hits           99       99              
- Misses         14       25      +11
Impacted Files Coverage Δ
src/metrics_distances.jl 26.66% <0%> (-73.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93c489f...263972c. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #33 into master will decrease coverage by 3.71%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   87.61%   83.89%   -3.72%     
==========================================
  Files           6        6              
  Lines         113      118       +5     
==========================================
  Hits           99       99              
- Misses         14       19       +5
Impacted Files Coverage Δ
src/metrics_distances.jl 44.44% <16.66%> (-55.56%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93c489f...e89364f. Read the comment docs.