Open johnnychen94 opened 5 years ago
Merging #33 into master will decrease coverage by
7.77%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 87.61% 79.83% -7.78%
==========================================
Files 6 6
Lines 113 124 +11
==========================================
Hits 99 99
- Misses 14 25 +11
Impacted Files | Coverage Δ | |
---|---|---|
src/metrics_distances.jl | 26.66% <0%> (-73.34%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 93c489f...263972c. Read the comment docs.
Merging #33 into master will decrease coverage by
3.71%
. The diff coverage is16.66%
.
@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 87.61% 83.89% -3.72%
==========================================
Files 6 6
Lines 113 118 +5
==========================================
Hits 99 99
- Misses 14 19 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/metrics_distances.jl | 44.44% <16.66%> (-55.56%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 93c489f...e89364f. Read the comment docs.
Before this patch there're 32 ambiguities, of which:
result_type
for metrics that are not yet tested and imported by ImageDistances.colwise!
forWeightEuclidean
that can be solved with one method definition.colwise!
forSqMahalanobis
andMahalanobisat
that can't be solved easily (at least in this repo).Details of ❌ : it should be
r::AbstractVector
for these two methods in the upstreamDistances.jl
. cc: @nalimilan