JuliaImages / ImageDistances.jl

Distances between N-dimensional images

https://github.com/JuliaImages/Images.jl

Other

15 stars 8 forks source link

Rely on ImageCore for Colors dependency #41

Closed timholy closed 4 years ago

timholy commented 4 years ago

Implements https://github.com/JuliaImages/Images.jl/issues/802

I took the liberty of bumping the version in anticipation of a release. I'm happy to back that out if maintainers prefer.

codecov[bot] commented 4 years ago

Codecov Report

Merging #41 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #41   +/-   ##
======================================
  Coverage    87.8%   87.8%           
======================================
  Files           6       6           
  Lines         123     123           
======================================
  Hits          108     108           
  Misses         15      15

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64728c5...858c0ca. Read the comment docs.

johnnychen94 commented 4 years ago

I think I need to revert https://github.com/JuliaImages/ImageDistances.jl/pull/34 first so that this package doesn't require Colors v0.9.6, otherwise, there's a probability that an incompatible version of Colors is used since ImageCore.jl in [0.8.3, 0.8.5] doesn't have lower bounds for that.

A probably simpler "alternative" is to limit the lower bound of ImageCore to v0.8.6?

https://github.com/JuliaImages/ImageCore.jl/compare/v0.8.5...v0.8.6

johnnychen94 commented 4 years ago

I'm merging this PR now since previous CI tests are already on ImageCore v0.8.8