search

JuliaImages / ImageDistances.jl

Distances between N-dimensional images
https://github.com/JuliaImages/Images.jl
Other
15 stars 8 forks source link

wrong build status #5

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 6 years ago

I successfully add and test this package, but the build status and building logs are still failed.

julia> versioninfo()
Julia Version 1.0.0
Commit 5d4eaca0c9 (2018-08-08 20:58 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
  CPU: Intel(R) Core(TM) i7-6800K CPU @ 3.40GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-6.0.0 (ORCJIT, broadwell)
Environment:
  JULIA_PATH = /usr/local/julia
  JULIA_GPG = 3673DF529D9049477F76B37566E3C7DC03D6E495
  JULIA_VERSION = 1.0.0

(v1.0) pkg> add ImageDistances
   Cloning default registries into /root/.julia/registries
   Cloning registry General from "https://github.com/JuliaRegistries/General.git"
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
 Resolving package versions...
 Installed Reexport ────────── v0.2.0
 Installed FixedPointNumbers ─ v0.5.3
 Installed ProgressMeter ───── v0.6.1
 Installed Distances ───────── v0.7.3
 Installed ColorTypes ──────── v0.7.5
 Installed Colors ──────────── v0.9.4
 Installed ImageDistances ──── v0.1.1
  Updating `~/.julia/environments/v1.0/Project.toml`
  [51556ac3] + ImageDistances v0.1.1
  Updating `~/.julia/environments/v1.0/Manifest.toml`
  [3da002f7] + ColorTypes v0.7.5
  [5ae59095] + Colors v0.9.4
  [b4f34e82] + Distances v0.7.3
  [53c48c17] + FixedPointNumbers v0.5.3
  [51556ac3] + ImageDistances v0.1.1
  [92933f4c] + ProgressMeter v0.6.1
  [189a3867] + Reexport v0.2.0
  [2a0f44e3] + Base64 
  [ade2ca70] + Dates 
  [8ba89e20] + Distributed 
  [b77e0a4c] + InteractiveUtils 
  [76f85450] + LibGit2 
  [8f399da3] + Libdl 
  [37e2e46d] + LinearAlgebra 
  [56ddb016] + Logging 
  [d6f4376e] + Markdown 
  [44cfe95a] + Pkg 
  [de0858da] + Printf 
  [3fa0cd96] + REPL 
  [9a3f8284] + Random 
  [ea8e919c] + SHA 
  [9e88b42a] + Serialization 
  [6462fe0b] + Sockets 
  [2f01184e] + SparseArrays 
  [10745b16] + Statistics 
  [8dfed614] + Test 
  [cf7118a7] + UUIDs 
  [4ec0a83e] + Unicode 

(v1.0) pkg> test ImageDistances
   Testing ImageDistances
    Status `/tmp/tmpmUHqbs/Manifest.toml`
  [3da002f7] ColorTypes v0.7.5
  [5ae59095] Colors v0.9.4
  [b4f34e82] Distances v0.7.3
  [53c48c17] FixedPointNumbers v0.5.3
  [51556ac3] ImageDistances v0.1.1
  [92933f4c] ProgressMeter v0.6.1
  [189a3867] Reexport v0.2.0
  [2a0f44e3] Base64  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Base64`]
  [ade2ca70] Dates  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Dates`]
  [8ba89e20] Distributed  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Distributed`]
  [b77e0a4c] InteractiveUtils  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/InteractiveUtils`]
  [76f85450] LibGit2  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/LibGit2`]
  [8f399da3] Libdl  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Libdl`]
  [37e2e46d] LinearAlgebra  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/LinearAlgebra`]
  [56ddb016] Logging  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Logging`]
  [d6f4376e] Markdown  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Markdown`]
  [44cfe95a] Pkg  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Pkg`]
  [de0858da] Printf  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Printf`]
  [3fa0cd96] REPL  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/REPL`]
  [9a3f8284] Random  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Random`]
  [ea8e919c] SHA  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/SHA`]
  [9e88b42a] Serialization  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Serialization`]
  [6462fe0b] Sockets  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Sockets`]
  [2f01184e] SparseArrays  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/SparseArrays`]
  [10745b16] Statistics  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Statistics`]
  [8dfed614] Test  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Test`]
  [cf7118a7] UUIDs  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/UUIDs`]
  [4ec0a83e] Unicode  [`/usr/local/julia/bin/../share/julia/stdlib/v1.0/Unicode`]
Test Summary:     | Pass  Total
ImageDistances.jl |   15     15
   Testing ImageDistances tests passed
timholy commented 5 years ago

Which status and logs? All that looks good.

johnnychen94 commented 5 years ago

Sorry that I didn't make this clear

The package itself goes well and pass the test. But the travis building status and its badge in README.md says the other way.

In https://travis-ci.org/JuliaImages/ImageDistances.jl/jobs/438420880#L520, it saysERROR: LoadError: ArgumentError: Package ImageDistances does not have EarthMoversDistance in its dependencies: but this package seems not used in this repository. Not very clear what's the problem with this.

timholy commented 5 years ago

Oh, got it. I hadn't paid much attention to this before, but it appears that the build link from the README.md points to the most recent PR, which indeed failed because it was a WIP which had known missing build dependencies (see #4).

I wonder if we should be more careful about this kind of thing. The list of branches on travis is https://travis-ci.org/JuliaImages/ImageDistances.jl/branches, and you can see master itself is passing. I'm not easily finding a URL which automatically points to the most recent build merged into master. Any ideas?

juliohm commented 5 years ago

We can always restart the builds in Travis and the badge should automatically update. The restart button is in the right side in the build spec.

On Mon, Oct 15, 2018, 06:54 Tim Holy notifications@github.com wrote:

Oh, got it. I hadn't paid much attention to this before, but it appears that the build link from the README.md points to the most recent PR, which indeed failed because it was a WIP which had known missing build dependencies (see #4 https://github.com/JuliaImages/ImageDistances.jl/pull/4).

I wonder if we should be more careful about this kind of thing. The list of branches on travis is https://travis-ci.org/JuliaImages/ImageDistances.jl/branches, and you can see master itself is passing. I'm not easily finding a URL which automatically points to the most recent build merged into master. Any ideas?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/JuliaImages/ImageDistances.jl/issues/5#issuecomment-429781173, or mute the thread https://github.com/notifications/unsubscribe-auth/ADMLberBjN8E5CDYS621i6Rxl--hnVvLks5ulFtRgaJpZM4XaB73 .

timholy commented 5 years ago

I know, but it seems a little weird to be "forced" to rebuild master every time someone submits a failing PR. That seems like a lot of manual work.

juliohm commented 5 years ago

Oh the badge is not pointing to master ? I will take a look when I get access to my computer

On Mon, Oct 15, 2018, 07:06 Tim Holy notifications@github.com wrote:

I know, but it seems a little weird to be "forced" to rebuild master every time someone submits a failing PR. That seems like a lot of manual work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/JuliaImages/ImageDistances.jl/issues/5#issuecomment-429785628, or mute the thread https://github.com/notifications/unsubscribe-auth/ADMLbS63cYKJTBzy1034FxM9_2H3KncBks5ulF36gaJpZM4XaB73 .

juliohm commented 5 years ago

I have no idea why the badge is pointing to the PR. Tim, if you can restart the builds marked with a X in this link we can see if the badge gets fixed: https://travis-ci.org/JuliaImages/ImageDistances.jl/builds/431284305

timholy commented 5 years ago

It wasn't the X builds that were the problem (we allow failures on nightly and that was where it happened to be), we just needed a build fresher than #4.

This did indeed fix the badge. Just need to figure out a better approach (this is probably an issue for many packages).

juliohm commented 5 years ago

I think I added a CRON job to the build to run every month. So the badge is updated automatically at this frequency. We could make it happen more frequently like every week.

Every now and then a specific build fails on Travis because of the cloud infrastructure and other issues unrelated to the actual changes in the codebase here.

johnnychen94 commented 5 years ago

Not very sure if this issue is completely fixed. Close it anyway.