Open johnnychen94 opened 3 years ago
I won't say it doesn't work because I used it today to makes its documentation But there is something buggy about how it works. The issue you mentioned above is there,
For me it's StackOverflowError
:
julia> versioninfo()
Julia Version 1.6.1
Commit 6aaedecc44 (2021-04-23 05:59 UTC)
Platform Info:
OS: macOS (x86_64-apple-darwin18.7.0)
CPU: Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
WORD_SIZE: 64
LIBM: libopenlibm
LLVM: libLLVM-11.0.1 (ORCJIT, skylake)
The same StackOverflowError
happened to me when I tried to fill a number of contours using BoundaryFill.
It's the issue with the recursive version and need better iterative solution or better checks in current one. Can you help fixing, it's great excercise to get comfortable with this package.
The recursive call of
BoundaryFill
simply blows up the call stack:https://github.com/JuliaImages/ImageDraw.jl/blob/54f3cfe4693fdc075cd17b6ac525daa7cb6288f8/src/polygonfill2d.jl#L14-L20
cc: @ashwani-rathee