search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

fix similar() and axes() for BorderArray #138

Closed Cody-G closed 4 years ago

Cody-G commented 4 years ago

Addresses #137

codecov[bot] commented 4 years ago

Codecov Report

Merging #138 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files           9        9           
  Lines        1173     1173           
=======================================
  Hits          995      995           
  Misses        178      178
Impacted Files Coverage Δ
src/borderarray.jl 86.15% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5232b63...a1bbbb9. Read the comment docs.

Cody-G commented 4 years ago

I also rolled in a fix for #139

Cody-G commented 4 years ago

Thanks for the reviews! I've addressed the comments and rebased. Just let me know if there are additional ways that I should be testing axes() and similar(), I'm not sure if I covered everything.

timholy commented 4 years ago

Thanks, @Cody-G!