search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

Swap symmetric and reflect in doc #141

Closed innerlee closed 4 years ago

innerlee commented 4 years ago

Fix https://github.com/JuliaImages/ImageFiltering.jl/issues/84

jw3126 commented 4 years ago

Can you add a doctest, like https://github.com/JuliaImages/ImageFiltering.jl/issues/84#issuecomment-438362454

innerlee commented 4 years ago

There is no doctest in this repo. Maybe you mean a test?

codecov[bot] commented 4 years ago

Codecov Report

Merging #141 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files           9        9           
  Lines        1173     1173           
=======================================
  Hits          995      995           
  Misses        178      178
Impacted Files Coverage Δ
src/imfilter.jl 86% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update caebc51...ed67cbb. Read the comment docs.

jw3126 commented 4 years ago

Oh wow it seems you are right, I can't spot any doctests. But I guess that is because this package is older then Documenter.jl or something like that and it is fine to add them @timholy ?

timholy commented 4 years ago

Yes, it would be great to add doctests. And indeed this package predates Documenter.