Open timholy opened 4 years ago
Merging #154 into master will decrease coverage by
0.32%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
- Coverage 91.65% 91.32% -0.33%
==========================================
Files 9 9
Lines 1222 1234 +12
==========================================
+ Hits 1120 1127 +7
- Misses 102 107 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/ImageFiltering.jl | 80.00% <ø> (ø) |
|
src/border.jl | 95.45% <ø> (-0.06%) |
:arrow_down: |
src/imfilter.jl | 89.55% <100.00%> (-1.26%) |
:arrow_down: |
src/kernelfactors.jl | 91.26% <0.00%> (-1.59%) |
:arrow_down: |
src/kernel.jl | 99.36% <0.00%> (-0.64%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ee6cf8e...7b500f6. Read the comment docs.
Bummer. Looks like they are still useful. I will have to dig deeper to figure out why.
Bizarre. I couldn't replicate the performance difference on my laptop for a couple of test cases. Let's see if the rebase somehow magically fixed something. (Seems unlikely, but still...)
This addresses "Update usage of OffsetArrays" in #142. It wasn't as ugly as I feared, but a nice cleanup nonetheless.
Do not merge this until we get benchmarks that let us assess the consequences of this change. (#152)