search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

Don't use FFT when input has NaNs #157

Closed yha closed 4 years ago

yha commented 4 years ago

This fixes filtering of floating-point arrays with NaN and large kernels. According to benchmarks on my machine, the time to check for NaNs is up to about 0.5% of the imfilter time (for img::Vector{Float64} and kernel of length 31).

codecov[bot] commented 4 years ago

Codecov Report

Merging #157 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files           9        9           
  Lines        1222     1222           
=======================================
  Hits         1120     1120           
  Misses        102      102

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d05973f...372eba5. Read the comment docs.

timholy commented 4 years ago

Nice, thanks!