JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations

Other

99 stars 51 forks source link

Fix tests to be agnostic to type printing #183

Closed goretkin closed 3 years ago

goretkin commented 3 years ago

https://github.com/JuliaLang/julia/pull/37085 changed how type parameters are printed, causing the following error:

Borders (issue #85): Test Failed at /home/runner/work/ImageFiltering.jl/ImageFiltering.jl/test/2d.jl:337
  Expression: imfilter(A, kern, Fill(0, (3,)))
    Expected: ArgumentError("Fill{Int64,1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")
      Thrown: ArgumentError("Fill{Int64, 1}(0, (3,), (3,)) lacks the proper padding sizes for an array with 2 dimensions")

See https://github.com/JuliaImages/ImageFiltering.jl/runs/1053929388?check_suite_focus=true#step:5:273 for the CI failure.

codecov[bot] commented 3 years ago

Codecov Report

Merging #183 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #183   +/-   ##
=======================================
  Coverage   77.60%   77.60%           
=======================================
  Files           9        9           
  Lines         978      978           
=======================================
  Hits          759      759           
  Misses        219      219

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c0ea6b...7f88cca. Read the comment docs.

johnnychen94 commented 3 years ago

Let's first check if it is stilling working wrt #182

goretkin commented 3 years ago

Did closing and opening trigger the CI? I wasn't sure why it didn't run to begin with.

johnnychen94 commented 3 years ago

I disabled the fail-fast option 11726578463e0f0190eab7aabe96d6a6d8c7d948 so that even if there's a test failure in nightly build, others are still running; a close and reopen would build the CI in the new master base.

johnnychen94 commented 3 years ago

A similar ambiguity issue is found in https://github.com/JuliaArrays/OffsetArrays.jl/pull/139 I'll go check it first this weekend and then revisit this PR.

timholy commented 3 years ago

The ambiguity issue might be changed or reverted; see https://github.com/JuliaLang/julia/pull/36962#issuecomment-687693851. I'm sitting pat for a while in my other repos, or just transiently disabling the ambiguity test.