search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 51 forks source link

Add max min filter demo #190

Closed Dsantra92 closed 3 years ago

Dsantra92 commented 3 years ago

189 Added demo for max, min filters

codecov[bot] commented 3 years ago

Codecov Report

Merging #190 into master will increase coverage by 0.47%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   91.14%   91.62%   +0.47%     
==========================================
  Files           9        9              
  Lines        1231     1385     +154     
==========================================
+ Hits         1122     1269     +147     
- Misses        109      116       +7
Impacted Files Coverage Δ
src/border.jl 94.15% <0.00%> (-1.39%) :arrow_down:
src/kernel.jl 100.00% <0.00%> (ø)
src/specialty.jl 100.00% <0.00%> (ø)
src/imfilter.jl 90.94% <0.00%> (+0.30%) :arrow_up:
src/kernelfactors.jl 93.66% <0.00%> (+0.80%) :arrow_up:
src/utils.jl 88.88% <0.00%> (+0.95%) :arrow_up:
src/ImageFiltering.jl 77.27% <0.00%> (+1.08%) :arrow_up:
src/mapwindow.jl 86.66% <0.00%> (+1.15%) :arrow_up:
src/borderarray.jl 92.59% <0.00%> (+2.88%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f4769e...951bc48. Read the comment docs.

johnnychen94 commented 3 years ago

FYI, to preview the result locally, you can activate julia with docs/ project, e.g.,

julia --project=docs/

and then run include("docs/make.jl") to generate the docs.

The generated HTML files can be found in docs/build, open it in your browser and you'll get a better feeling on the changes.

Dsantra92 commented 3 years ago

Looks like I messed up a lot.I am working on the fixes.

johnnychen94 commented 3 years ago

Oops sorry for the back-and-forth, I just realized that @timholy has implemented a faster version of maxmin filter using the Lemire filters

I'm not sure how this could be used efficiently, @timholy would you mind give some suggestions on this?

timholy commented 3 years ago

mapwindow(extrema, img, window).

Dsantra92 commented 3 years ago

I have made few changes as requested, hoping that it will make the cut.

johnnychen94 commented 3 years ago

It now looks awesome and I think it's ready to merge. Thanks for all the polishing work.

I've adjusted the filter size to make the result look nicer. If you are good with this, I can get it merged.

Dsantra92 commented 3 years ago

The new example looks good to me.

johnnychen94 commented 3 years ago

Thanks again for the work!