search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

Fix some ambiguities on nightly #191

Closed timholy closed 3 years ago

timholy commented 3 years ago

The new algorithm for detecting ambiguities picked up some real ones that, surprisingly, were not detected previously.

Thanks to @vtjnash

codecov[bot] commented 3 years ago

Codecov Report

Merging #191 into master will increase coverage by 0.48%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   91.14%   91.63%   +0.48%     
==========================================
  Files           9       18       +9     
  Lines        1231     2772    +1541     
==========================================
+ Hits         1122     2540    +1418     
- Misses        109      232     +123
Impacted Files Coverage Δ
src/ImageFiltering.jl 77.27% <ø> (+1.08%) :arrow_up:
src/border.jl 94.15% <0.00%> (-1.39%) :arrow_down:
src/borderarray.jl 92.59% <25.00%> (+2.88%) :arrow_up:
src/kernel.jl 100.00% <0.00%> (ø)
src/specialty.jl 100.00% <0.00%> (ø)
...ltering.jl/ImageFiltering.jl/src/ImageFiltering.jl 77.27% <0.00%> (ø)
...ageFiltering.jl/ImageFiltering.jl/src/mapwindow.jl 86.66% <0.00%> (ø)
.../ImageFiltering.jl/ImageFiltering.jl/src/border.jl 94.15% <0.00%> (ø)
...ageFiltering.jl/ImageFiltering.jl/src/specialty.jl 100.00% <0.00%> (ø)
...eFiltering.jl/ImageFiltering.jl/src/borderarray.jl 92.59% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5f4769e...e23fb6f. Read the comment docs.

timholy commented 3 years ago

I don't think there's anything controversial here, so merging.