JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

CompatHelper: bump compat for "StaticArrays" to "1.0" #196

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the StaticArrays package from 0.10, 0.11, 0.12 to 0.10, 0.11, 0.12, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

mateuszbaran commented 3 years ago

Bump.

timholy commented 3 years ago

CI never ran. Let's try again.

codecov[bot] commented 3 years ago

Codecov Report

Merging #196 (54fa904) into master (91fa4a3) will decrease coverage by 0.92%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   91.62%   90.70%   -0.93%     
==========================================
  Files           9        9              
  Lines        1385     1237     -148     
==========================================
- Hits         1269     1122     -147     
+ Misses        116      115       -1     
Impacted Files Coverage Δ
src/borderarray.jl 85.91% <0.00%> (-6.68%) :arrow_down:
src/mapwindow.jl 85.50% <0.00%> (-1.16%) :arrow_down:
src/ImageFiltering.jl 76.19% <0.00%> (-1.09%) :arrow_down:
src/utils.jl 87.93% <0.00%> (-0.96%) :arrow_down:
src/kernelfactors.jl 92.85% <0.00%> (-0.81%) :arrow_down:
src/border.jl 93.75% <0.00%> (-0.41%) :arrow_down:
src/imfilter.jl 90.63% <0.00%> (-0.31%) :arrow_down:
src/kernel.jl 100.00% <0.00%> (ø)
src/specialty.jl 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91fa4a3...54fa904. Read the comment docs.

johnnychen94 commented 3 years ago

CI never ran. Let's try again.

This is because a GitHub action(CompatHelper) could not trigger another GitHub action unless we configure the COMPATHELPER_PRIV environment variable.

Ref: https://github.com/JuliaRegistries/CompatHelper.jl#121-motivation

I'm doing MassInstallation on all repos under JuliaImages and reuse our TAGBOT key. I'll also bump our tag bot CI wrt (https://github.com/JuliaGraphics/Colors.jl/pull/449)

timholy commented 3 years ago

Thanks, @johnnychen94! I played with MassInstallAction just this past week on my own personal repositories, and so far it doesn't seem to have broken anything that I know of, but I haven't really made that many PRs since then so I was still a little unsure. I appreciate you taking this brave step!