search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 51 forks source link

partially revert "Fix some ambiguities on nightly (#191)" #199

Closed johnnychen94 closed 3 years ago

johnnychen94 commented 3 years ago

This partially revert commits 0ae368d27b7905773aa114d43d417c1fabe0b9b6

@timholy we need to merge this before we tag a release

codecov[bot] commented 3 years ago

Codecov Report

Merging #199 (9bb05ac) into master (67116e5) will increase coverage by 0.89%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   90.70%   91.59%   +0.89%     
==========================================
  Files           9        9              
  Lines        1237     1380     +143     
==========================================
+ Hits         1122     1264     +142     
- Misses        115      116       +1
Impacted Files Coverage Δ
src/borderarray.jl 92.50% <ø> (+6.58%) :arrow_up:
src/kernel.jl 100.00% <0.00%> (ø)
src/specialty.jl 100.00% <0.00%> (ø)
src/imfilter.jl 90.94% <0.00%> (+0.30%) :arrow_up:
src/border.jl 94.15% <0.00%> (+0.40%) :arrow_up:
src/kernelfactors.jl 93.57% <0.00%> (+0.71%) :arrow_up:
src/utils.jl 88.88% <0.00%> (+0.95%) :arrow_up:
src/ImageFiltering.jl 77.27% <0.00%> (+1.08%) :arrow_up:
src/mapwindow.jl 86.66% <0.00%> (+1.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67116e5...9bb05ac. Read the comment docs.

timholy commented 3 years ago

Oh rats, I didn't see this before submitting https://github.com/JuliaRegistries/General/pull/26043. I'm going to merge this now and then push a new registration on top of that before the 15-minute automatic merge window.