search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 51 forks source link

resolve_window method ambiguity #208

Closed JeffFessler closed 3 years ago

JeffFessler commented 3 years ago

I just learned about Aqua.jl and decided to try it on some of my favorite packages like this one. It reported exactly one method ambiguity here:

resolve_window(window::Tuple{Vararg{Int64,N}} where N) in ImageFiltering.MapWindow at /Users/fessler/.julia/dev/ImageFiltering/src/mapwindow.jl:122

resolve_window(window::Tuple{Vararg{AbstractUnitRange,N}} where N) in ImageFiltering.MapWindow at /Users/fessler/.julia/dev/ImageFiltering/src/mapwindow.jl:134

The only ambiguity is for the empty Tuple () so I've added a 1-line fix to #207.

johnnychen94 commented 3 years ago

Seems to be fixed by #207 already.