JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 51 forks source link

Migrate from SnoopPrecompile to PrecompileTools #257

Closed timholy closed 1 year ago

timholy commented 1 year ago

This pull request migrates the package from SnoopPrecompile to PrecompileTools. PrecompileTools is nearly a drop-in replacement except that there are changes in naming and how developers locally disable precompilation (to make their development workflow more efficient). These changes are described in PrecompileTool's enhanced documentation, which also includes instructions for users on how to set up custom "Startup" packages, handling precompilation tasks that are not amenable to workloads, and tips for troubleshooting.

Why the new package? It meets several goals:

For more information and discussion, see this discourse post.

mkitti commented 1 year ago

@johnnychen94 , can we merge this?

mkitti commented 1 year ago

Retriggered-CI just to check

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06 :warning:

Comparison is base (baedd6d) 94.34% compared to head (5ddcef4) 94.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #257 +/- ## ========================================== - Coverage 94.34% 94.28% -0.06% ========================================== Files 13 13 Lines 1697 1697 ========================================== - Hits 1601 1600 -1 - Misses 96 97 +1 ``` | [Impacted Files](https://app.codecov.io/gh/JuliaImages/ImageFiltering.jl/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/precompile.jl](https://app.codecov.io/gh/JuliaImages/ImageFiltering.jl/pull/257?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL3ByZWNvbXBpbGUuamw=) | `100.00% <100.00%> (ø)` | | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/JuliaImages/ImageFiltering.jl/pull/257/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

timholy commented 1 year ago

Hah, quite hilarious I didn't notice that I'd never merged this.

timholy commented 1 year ago

Do you want me to make a new release or are you checking other issues first?