search

JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 51 forks source link

Incorrect usage of `threadid` #265

Closed cafaxo closed 11 months ago

cafaxo commented 11 months ago

This usage of threadid definitely does not look correct: https://github.com/JuliaImages/ImageFiltering.jl/blob/afd33f4e2903bc29f37cfe38afc2b7d7ff1142d8/src/imfilter.jl#L487-L493 See https://julialang.org/blog/2023/07/PSA-dont-use-threadid/#the_buggy_pattern

mkitti commented 11 months ago

This probably should at least use the static scheduler if not be refactored.

IanButterworth commented 11 months ago

I would refactor it. Using the static scheduler isn't a great stopgap re. composability