JuliaImages / ImageFiltering.jl

Julia implementations of multidimensional array convolution and nonlinear stencil operations
Other
99 stars 49 forks source link

Fixes for various Julia versions #89

Closed timholy closed 5 years ago

timholy commented 5 years ago

The first commit gets the tests passing with the new IdentityUnitRange on Julia 1.1. The second is due to my failure to tag https://github.com/JuliaLang/julia/pull/30164 with a backport label.

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will increase coverage by 20.48%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
+ Coverage   62.56%   83.05%   +20.48%     
===========================================
  Files           8        8               
  Lines        1074     1086       +12     
===========================================
+ Hits          672      902      +230     
+ Misses        402      184      -218
Impacted Files Coverage Δ
src/kernel.jl 96.9% <100%> (+14.43%) :arrow_up:
src/ImageFiltering.jl 78.57% <50%> (-1.43%) :arrow_down:
src/utils.jl 64.28% <0%> (+10.71%) :arrow_up:
src/kernelfactors.jl 75.83% <0%> (+16.16%) :arrow_up:
src/imfilter.jl 84.16% <0%> (+20.33%) :arrow_up:
src/border.jl 84.66% <0%> (+20.91%) :arrow_up:
src/specialty.jl 88.23% <0%> (+23.52%) :arrow_up:
src/mapwindow.jl 79.03% <0%> (+29.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b66231...29a873a. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into master will increase coverage by 20.48%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
+ Coverage   62.56%   83.05%   +20.48%     
===========================================
  Files           8        8               
  Lines        1074     1086       +12     
===========================================
+ Hits          672      902      +230     
+ Misses        402      184      -218
Impacted Files Coverage Δ
src/kernel.jl 96.9% <100%> (+14.43%) :arrow_up:
src/ImageFiltering.jl 78.57% <50%> (-1.43%) :arrow_down:
src/utils.jl 64.28% <0%> (+10.71%) :arrow_up:
src/kernelfactors.jl 75.83% <0%> (+16.16%) :arrow_up:
src/imfilter.jl 84.16% <0%> (+20.33%) :arrow_up:
src/border.jl 84.66% <0%> (+20.91%) :arrow_up:
src/specialty.jl 88.23% <0%> (+23.52%) :arrow_up:
src/mapwindow.jl 79.03% <0%> (+29.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3b66231...29a873a. Read the comment docs.