Closed IanButterworth closed 2 years ago
Thanks for proposing the new functionalities. I just come back from vacation; will try this out and fix the test tomorrow night.
@johnnychen94 just checking in on this. I believe your plan was to extend it to ImageShow first?
Yes, I feel it a little bit hard to maintain by mixing both terminal display and keyboard IO control. So I want to put the keyboard IO control part to ImageShow, and then extend the terminal display feature here. That said, ImageInTerminal will depend on ImageShow in the future.
I'm recently started to finish my pending PRs, and this is on my to-do list.
So I want to put the keyboard IO control part to ImageShow
Ideally, we need an independent package (maybe KeyboardEvents.jl
) for this, but I'm a little bit reluctant to have more packages given my limited time here...
Superseded by https://github.com/JuliaImages/ImageShow.jl/pull/29.
I thought these methods would make more sense in here than in https://github.com/IanButterworth/VideoInTerminal.jl given they require no further deps, and feel like an extension of current ImageInTerminal offerings.
The methods that depend on VideoIO could stay in VideoInTerminal (like the webcam viewer.. which I recommend trying out!)
It's so awesome how well this works ImageInTerminal. The frame rates are really impressive. Nice work!