JuliaImages / ImageSegmentation.jl

Partitioning images into meaningful regions
Other
47 stars 23 forks source link

Fix deprecations #12

Closed femtocleaner[bot] closed 7 years ago

femtocleaner[bot] commented 7 years ago

I fixed a number of deprecations for you

timholy commented 7 years ago

Hmm, I thought I had to trigger this manually. Once it gets through CI, any objections to merging this? It might cause merge conflicts elsewhere, of course.

codecov[bot] commented 7 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   99.09%   99.32%   +0.22%     
==========================================
  Files           7        7              
  Lines         444      443       -1     
==========================================
  Hits          440      440              
+ Misses          4        3       -1
Impacted Files Coverage Δ
src/core.jl 100% <ø> (ø) :arrow_up:
src/felzenszwalb.jl 100% <ø> (ø) :arrow_up:
src/fast_scanning.jl 100% <100%> (+1.51%) :arrow_up:
src/region_growing.jl 100% <100%> (ø) :arrow_up:
src/watershed.jl 97.5% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbb1b33...7cdd03c. Read the comment docs.

Keno commented 7 years ago

Hmm, I thought I had to trigger this manually

It gets triggered once upon installation and then every time you update REQUIRE to include a new julia version (though it won't open a PR if there's no changes to be made).

annimesh2809 commented 7 years ago

No objections from my side.