search

JuliaImages / ImageSegmentation.jl

Partitioning images into meaningful regions
Other
47 stars 23 forks source link

Fixes #20 #21

Closed mauro3 closed 6 years ago

mauro3 commented 6 years ago

This fixes #20 for me. Although, I don't understand what this line does, so please check that \div is correct.

timholy commented 6 years ago

Thanks for contributing this!

I'd say a better fix would be to change the allocation of the result type (all the Images.accum(T) lines) to call something like this:

meantype(::Type{T}) where T = Images.accum(T)
meantype(::Type{T}) where T<:Integer = Float64

Could you throw in a test, too? The demo in #20 would be perfect.

mauro3 commented 6 years ago

Updated (some trailing whitespace was also removed)

codecov[bot] commented 6 years ago

Codecov Report

Merging #21 into master will decrease coverage by 0.77%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   98.23%   97.46%   -0.78%     
==========================================
  Files           9        9              
  Lines         511      513       +2     
==========================================
- Hits          502      500       -2     
- Misses          9       13       +4
Impacted Files Coverage Δ
src/felzenszwalb.jl 100% <100%> (ø) :arrow_up:
src/ImageSegmentation.jl 0% <0%> (-100%) :arrow_down:
src/fast_scanning.jl 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ed3b4f...1ffad3e. Read the comment docs.

timholy commented 6 years ago

Lovely, many thanks!

timholy commented 6 years ago

New release submitted to METADATA.