Closed timholy closed 5 years ago
Ah, wait, v0.5 of SimpleWeightedGraphs can be installed on 0.7. There is a depwarn, but it's not critical.
I'm ok with changing the lower bound of Julia in the REQUIRE, but I don't know how that works, exactly, when a later tagged version of SWG has a bound that's less than a previous version. Advice on how to proceed?
Not certain, but I'd start by seeing what feedback you get with a METADATA PR that lowers the julia version requirement from 1.0 to 0.7. (i.e., edit ~/.julia/v0.6/METADATA/SimpleWeightedGraphs/versions/1.0.0/requires
and submit a PR). If that's not the right thing to do someone will let you know.
Not critical, though, since 0.5 mostly works.
Merging #29 into master will increase coverage by
1.68%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #29 +/- ##
==========================================
+ Coverage 97.46% 99.15% +1.68%
==========================================
Files 9 7 -2
Lines 513 354 -159
==========================================
- Hits 500 351 -149
+ Misses 13 3 -10
Impacted Files | Coverage Δ | |
---|---|---|
src/fast_scanning.jl | 100% <100%> (ø) |
:arrow_up: |
src/felzenszwalb.jl | 100% <100%> (ø) |
:arrow_up: |
src/meanshift.jl | 100% <100%> (ø) |
:arrow_up: |
src/region_growing.jl | 100% <100%> (ø) |
:arrow_up: |
src/region_merging.jl | 91.66% <100%> (-3.79%) |
:arrow_down: |
src/core.jl | 100% <100%> (+1.06%) |
:arrow_up: |
src/watershed.jl | 96.29% <100%> (-1.21%) |
:arrow_down: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6d23970...fcdda88. Read the comment docs.
One problem is that SimpleWeightedGraphs nominally only supports Julia 1.0 and higher, even though it works on 0.7 (I tested) if you lower the Julia version bounds in its REQUIRE. Consequently I expect tests to fail here on 0.7, but only because of Pkg resolver issues.
Can we fix that, @sbromberger and @jpfairbanks?