JuliaImages / ImageSegmentation.jl

Partitioning images into meaningful regions
Other
47 stars 23 forks source link

Updates in documentation, and fixes in mean eltype computation #30

Closed timholy closed 5 years ago

timholy commented 5 years ago

I'm in the process of updating https://juliaimages.github.io/latest/ to Julia 1.0, and found these to be important issues to address. Some of the changes presumably reflect Documenter changes (e.g., it seems pickier about whitespace), but it was also the occasion to discover some problems with how we decide on the element type of a segment mean. In particular, this type should be consistent with division by an integer, and hence typically floating-point valued (though Rational{Int} would also work). Some of the doctests at https://juliaimages.github.io/latest/ were giving InexactErrors; this PR should fix those problems.

codecov[bot] commented 5 years ago

Codecov Report

Merging #30 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   99.15%   99.15%   +<.01%     
==========================================
  Files           7        7              
  Lines         354      356       +2     
==========================================
+ Hits          351      353       +2     
  Misses          3        3
Impacted Files Coverage Δ
src/core.jl 100% <ø> (ø) :arrow_up:
src/fast_scanning.jl 100% <100%> (ø) :arrow_up:
src/felzenszwalb.jl 100% <100%> (ø) :arrow_up:
src/watershed.jl 96.29% <100%> (ø) :arrow_up:
src/meanshift.jl 100% <100%> (ø) :arrow_up:
src/region_growing.jl 100% <100%> (ø) :arrow_up:
src/region_merging.jl 91.66% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 884af7c...db7ce9a. Read the comment docs.