search

JuliaImages / ImageSegmentation.jl

Partitioning images into meaningful regions
Other
47 stars 23 forks source link

Rename `rem_segment` -> `remove_segment` #47

Closed timholy closed 4 years ago

timholy commented 4 years ago

I noticed this because of a docstring warning (https://github.com/JuliaImages/ImageSegmentation.jl/pull/7#discussion_r127701915).

Other options include delete_segment. Thoughts?

johnnychen94 commented 4 years ago

I'm a little unfamiliar with the codebase but generally speaking, this rename follows the naming guideline https://github.com/JuliaImages/Images.jl/issues/767 so :+1:

timholy commented 4 years ago

https://travis-ci.org/github/JuliaImages/ImageSegmentation.jl/builds/675255043

(I am trying to figure out what's wrong with Travis.)