search

JuliaImages / ImageShow.jl

Inline graphical display of images in Julia graphical environments
MIT License
26 stars 9 forks source link

Use of PNGFiles instead of ImageMagick #20

Closed kimikage closed 4 years ago

kimikage commented 4 years ago

I think ImageShow.jl only use the PNG generation function of ImageMagick, so ImageMagick can be replaced by the new package PNGFIles.

Perhaps when we use ImageShow without image files other than PNG, PNGFiles is better. However, in many cases, other packages in use depend on ImageMagick, so it is not always better.

johnnychen94 commented 4 years ago

Good idea, but I think that requires PNGFiles to support savestreaming method to suit https://github.com/JuliaImages/ImageShow.jl/blob/026ccda2f99536b2711fc599b2cd8da95ce5573d/src/showmime.jl#L45

Once that's done, ImageMagick will be automatically replaced by PNGFiles if the user has it installed.

cc: @ianshmean

kimikage commented 4 years ago

Well, I assumed the usage without the FileIO and streaming. In any case, we need to extend PNGFiles.

johnnychen94 commented 4 years ago

With https://github.com/JuliaIO/PNGFiles.jl/pull/14 merged, I think this is good to close; FileIO would use ImageIO if available.

IanButterworth commented 4 years ago

PNGFiles does indeed support streams now, and I’ll be adding support in ImageIO once PNGfiles releases. Should all be released today

IanButterworth commented 4 years ago

Released as of ImageIO 0.2.0 👍