Closed roflmaostc closed 1 year ago
Base: 87.98% // Head: 88.32% // Increases project coverage by +0.34%
:tada:
Coverage data is based on head (
e0f6073
) compared to base (245e0e4
). Patch coverage: 91.30% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@tlnagy do you happen to have some suggestion/feedback on this? For instance, does this function suits your need for #41?
Hi! Just wanted to ping this again :)
Sorry for the delay @roflmaostc, but this looks a nifty and it works on my end:
It would be great if you add support for signed fixed point numbers (as discussed in #41 like @johnnychen94 mentioned), which currently have the awful behavior of:
I think something simple like subtyping on Gray{<: Fixed}
and then centering the display at 0 (similar to the functions you already have implemented) would be fantastic.
Thank, I'll try to look into it!
I probably remove the parameter f
inside simshow
because it's rather useless.
@tlnagy do we introduce a new dependency for the FixedPointNumbers.jl?
FixedPointNumbers and Colors are always included as long as ImageCore is loaded https://github.com/JuliaImages/ImageCore.jl/blob/fc9ac05630ac07876963d412a295fade46e0094e/src/ImageCore.jl#L4-L6
Would it be OK to convert the FixedPointNumbers to Float for displaying it?
Error such this occur:
rgumentError: FixedPointNumbers.Q0f7 is an 8-bit type representing 256 values from -1.0 to 0.992; cannot represent 1
What should I do in this case? Even the operation arr = set_zero ? arr .- minimum(arr) : arr
can't be represented in FixedPointNumbers in some cases.
So think I can't recycle the other functionalities very well (how would a gamma work?).
Is something like this ok?
function simshow(arr::AbstractArray{Colors.Gray{T}}) where {T<:Fixed}
return simshow(Array{Gray{Float64}}(arr))
end
What's the state of it?
I really use that every day and need to copy paste it all the time :laughing:
I was waiting for more people involved because I'm not so active here these days; nevertheless, let's merge this and give it a try since it's a greenfield implementation, and I don't see it harmful to the existing codebase.
Should we advertise it a little more, like in: https://github.com/roflmaostc/SimpleImageView.jl
As discussed in #55
Would be happy to receive feedback :)
Right now it basically displays only 2D arrays.
I think it would be nice to have the option for 3D arrays to be shown as RGB, if possible.
For other 3D arrays I think we can just error because
simshow
is not a fully fledged viewer but instead a simple viewer for inline displays of arrays