JuliaImages / ImageSmooth.jl

Image smoothing algorithms
MIT License
7 stars 1 forks source link

Implement "Generalized Smoothing Framework" and related algorithms #15

Open johnnychen94 opened 2 years ago

johnnychen94 commented 2 years ago

There exists a series of nice work on smoothing filters that I think we can easily bring to Julia:

cc: @wliusjtu

wliusjtu commented 2 years ago

H i D r . C h e n ,

M a n y t h a n k s f o r y o u r i n t e r e s t i n o u r w o r k , a n d s o r r y f o r t h e l a t e r e p l y b e c a u s e I h a v e n o t c h e c k e d t h i s m a i l b o x f o r a p e r i o d o f t i m e . I t h i n k y o u c a n e a s i l y i n c l u d e o u r r e l e a s e d c o d e i n t o y o u r l i b r a r y . A s f o r t h e l i c e n s e , I a m n o t c l e a r w h i c h k i n d a l i c e n s e o u r c o d e a p p l i e s . I t h i n k a l l o f o u r c o d e i s f r e e f o r n o n - c o m m e r c i a l u s e , a n d y o u j u s t n e e d t o l i s t o u r p a p e r i n t h e c o r r e s p o n d i n g c o d e r e p o s i t o r i e s . E v e r y o n e c a n f r e e l y u s e o u r c o d e f o r a c a d e m i c p u r p o s e s , a n d a l l h e / s h e n e e d s t o d o i s t o c i t e o u r p a p e r . I n a d d i t i o n , I t h i n k o u r a n o t h e r w o r k c o u l d a l s o b e i n c l u d e d i n y o u r l i b r a r y : h t t p s : / / g i t h u b . c o m / w l i u s j t u / S e m i - G l o b a l - W e i g h t e d - L e a s t - S q u a r e s - i n - I m a g e - F i l t e r i n g


B e s t R e g a r d s ,

W e i L i u

F r o m : J o h n n y C h e n S e n t : 2 0 2 1 t^1 0 g8 åe 2 0 : 3 2 T o : J u l i a I m a g e s / I m a g e S m o o t h . j l C c : W e i L i u ; M e n t i o n S u b j e c t : [ J u l i a I m a g e s / I m a g e S m o o t h . j l ] I m p l e m e n t " G e n e r a l i z e d S m o o t h i n g F r a m e w o r k " a n d r e l a t e d a l g o r i t h m s (

1 5 )

T h e r e e x i s t s a s e r i e s o f n i c e w o r k o n s m o o t h i n g f i l t e r s t h a t I t h i n k w e c a n e a s i l y b r i n g t o J u l i a : " h t t p s : / / g i t h u b . c o m / w l i u s j t u / G e n e r a l i z e d - S m o o t h i n g - F r a m e w o r k " h t t p s : / / g i t h u b . c o m / w l i u s j t u / R e a l - t i m e - I m a g e - S m o o t h i n g - v i a - I t e r a t i v e - L e a s t - S q u a r e s " h t t p s : / / g i t h u b . c o m / w l i u s j t u / E m b e d d i n g - B i l a t e r a l - F i l t e r - i n - L e a s t - S q u a r e s - f o r - E f f i c i e n t - E d g e - p r e s e r v i n g - I m a g e - S m o o t h i n g c c : @ w l i u s j t u

Y o u a r e r e c e i v i n g t h i s b e c a u s e y o u w e r e m e n t i o n e d . R e p l y t o t h i s e m a i l d i r e c t l y , v i e w i t o n G i t H u b , o r u n s u b s c r i b e . T r i a g e n o t i f i c a t i o n s o n t h e g o w i t h G i t H u b M o b i l e f o r i O S o r A n d r o i d .

wliusjtu commented 2 years ago

Hi Dr. Chen Many   thanks   for   your   interest in our work, and sorry for the later reply because I have not checked this mail box for a period of time. I think you can easily include our released code into your library. As for the license, I am not sure which kind of license our code applies. I think all our code if free for “non-commercial” use, and you just need to list our paper in the corresponding code repository. Everyone can freely use our code for academic purposes, and all he/she needs to do is to cite our paper. In addition, I think our another work published in ICCV could also be included in your library: https://github.com/wliusjtu/Semi-Global-Weighted-Least-Squares-in-Image-Filtering  ------------------------------Best Regards, Wei Liu From: Johnny ChenSent: 2021年10月8日 20:32To: JuliaImages/ImageSmooth.jlCc: Wei Liu; MentionSubject: [JuliaImages/ImageSmooth.jl] Implement "Generalized Smoothing Framework" and related algorithms (#15) There exists a series of nice work on smoothing filters that I think we can easily bring to Julia:https://github.com/wliusjtu/Generalized-Smoothing-Frameworkhttps://github.com/wliusjtu/Real-time-Image-Smoothing-via-Iterative-Least-Squareshttps://github.com/wliusjtu/Embedding-Bilateral-Filter-in-Least-Squares-for-Efficient-Edge-preserving-Image-Smoothingcc: @wliusjtu—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.  

johnnychen94 commented 2 years ago

Thanks for the reply!

I think all our code if free for “non-commercial” use, and you just need to list our paper in the corresponding code repository.

There might be some misunderstanding of the term "non-commercial" use. Does this imply 1) people can't use your code for commercial use, or, 2) people can use your code for commercial use but you're not responsible for any potential outcomes (whether they are good or bad)? My best guess from your context is that you meant the second one?

I ask this because none of the widely-used open-source licenses have restrictions to "commercial" usage. You can take a quick check of https://choosealicense.com/licenses/. Most Julia packages (including this one) adopts the MIT license so that we would allow arbitrary use of the codes with a conditional credit to the package and authors.


As a suggestion, you can take a look at https://choosealicense.com/licenses/, choose your favorite license and upload them to all your code repos as filename LICENSE, this helps avoid future similar license questions from others.

wliusjtu commented 2 years ago

Hi Johnny Chen, Many thanks for your reply. I have updated the license, please check them.

Best Regards, Wei Liu