Closed JKay0327 closed 3 years ago
Merging #6 (7741140) into master (500f97c) will increase coverage by
22.52%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #6 +/- ##
============================================
+ Coverage 77.47% 100.00% +22.52%
============================================
Files 4 2 -2
Lines 111 69 -42
============================================
- Hits 86 69 -17
+ Misses 25 0 -25
Impacted Files | Coverage Δ | |
---|---|---|
src/SmoothAPI/smooth.jl | 100.00% <100.00%> (ø) |
|
src/algorithms/l0_smooth.jl | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 500f97c...7741140. Read the comment docs.
Use squash and merge when you're ready.
Some improvement
ImageBase.fdiff
is used to improve the performance, solves https://github.com/johnnychen94/ImageSmooth.jl/issues/4#issue-963142327similar(float64.(input))
orsum()
, solves https://github.com/johnnychen94/ImageSmooth.jl/issues/3#issue-963142254Previous performance is as follow:
Current performance is as follow:
We can see that the allocations are extremely reduced, however, the improvement of running time is not as remarkable as the allocations.
Maybe we can do some further improvement, or the main time-consuming factor is the process of
fft!
andifft!
so that the performance of this algorithm stay at this level.