search

JuliaImages / ImageTracking.jl

Other
26 stars 8 forks source link

Add dense flow visualization function #18

Closed Deepank308 closed 5 years ago

Deepank308 commented 5 years ago

Function for visualizing dense optical flow vectors in HSV color space is added as utility.jl file.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will decrease coverage by 1.54%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage    64.2%   62.66%   -1.55%     
==========================================
  Files           5        6       +1     
  Lines         366      375       +9     
==========================================
  Hits          235      235              
- Misses        131      140       +9
Impacted Files Coverage Δ
src/Utility.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbda439...2625fab. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #18 into master will decrease coverage by 1.37%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage    64.2%   62.83%   -1.38%     
==========================================
  Files           5        6       +1     
  Lines         366      374       +8     
==========================================
  Hits          235      235              
- Misses        131      139       +8
Impacted Files Coverage Δ
src/utility.jl 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bbda439...f414e2c. Read the comment docs.

Deepank308 commented 5 years ago

Ping @zygmuntszpak

Deepank308 commented 5 years ago

@zygmuntszpak, I have made the requested changes. Sorry for taking too much time

zygmuntszpak commented 5 years ago

@Deepank308 Thanks for working on this. I noticed that all of the builds failed because you added using ImageView in the visualization.jl test script. Is ImageView really needed for the test? I suspect that you do not need most of the using ... statements for your particular test script. If you do need a particular one I believe you will need to list the package as a dependency in the REQUIRE file.

I suggest you check each of your using ... statements to verify that your test script truly requires them.

Deepank308 commented 5 years ago

@zygmuntszpak I can't understand why AppVeyor build failed again. I don't think this fail is due to some mistake in visualization.jl test script. Other than that all the bulids have passed. Please review and suggest if any changes are to be made.

zygmuntszpak commented 5 years ago

Hi Deepank, I think the one AppVeyor fail was a glitch of AppVeyor itself. Thanks for your work on this pull-request. I'm sorry that my feedback has been so intermittent.

Deepank308 commented 5 years ago

Thank you so much for merging!!