search

JuliaImages / ImageTracking.jl

Other
26 stars 8 forks source link

Adds haar-like features #2

Closed arijitkar98 closed 6 years ago

arijitkar98 commented 6 years ago

These features will be required for the MIL and Boosting trackers. I will add some tests by tomorrow.

arijitkar98 commented 6 years ago

Added tests. Ping @zygmuntszpak

codecov[bot] commented 6 years ago

Codecov Report

Merging #2 into master will increase coverage by 3.95%. The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #2      +/-   ##
==========================================
+ Coverage   89.25%   93.21%   +3.95%     
==========================================
  Files           2        5       +3     
  Lines         121      280     +159     
==========================================
+ Hits          108      261     +153     
- Misses         13       19       +6
Impacted Files Coverage Δ
src/haar.jl 98.11% <98.11%> (ø)
src/lucas_kanade.jl 88.54% <0%> (-0.53%) :arrow_down:
src/core.jl 100% <0%> (ø)
src/farneback.jl 95.89% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0025214...cfa21f2. Read the comment docs.

arijitkar98 commented 6 years ago

@zygmuntszpak Could you review this once you get time.

zygmuntszpak commented 6 years ago

Apart from the aforementioned change, I suggest you also add variants of haar_features and haar_coordinates which take a tuple to specify top_left and bottom_right.

Apart from that it looks good to me. I still think there are some odd memory allocations happening, but at this point I don't know how to fix that. Hence, once you make the small amendments we should be good to merge.