search

JuliaImages / ImageTracking.jl

Other
26 stars 8 forks source link

Update Project.toml #23

Closed johnnychen94 closed 5 years ago

johnnychen94 commented 5 years ago

The current Project.toml is invalid. ] add https://github.com/JuliaImages/ImageTracking.jl gives expect a name entry in project file at */Project.toml

~* ImageFiltering is reexported by Images~

zygmuntszpak commented 5 years ago

I think that ultimately we don't want to depend on Images if Images is meant to be an umbrella package. I reckon it would be better to keep ImageFiltering and figure out what other dependencies in Images we need so that we can import those specific ones and remove the Images dependency.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e329ec). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   61.39%           
=========================================
  Files             ?        7           
  Lines             ?      443           
  Branches          ?        0           
=========================================
  Hits              ?      272           
  Misses            ?      171           
  Partials          ?        0
Impacted Files Coverage Δ
src/ImageTracking.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e329ec...6316cf9. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@7e329ec). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage          ?   61.39%           
=========================================
  Files             ?        7           
  Lines             ?      443           
  Branches          ?        0           
=========================================
  Hits              ?      272           
  Misses            ?      171           
  Partials          ?        0
Impacted Files Coverage Δ
src/ImageTracking.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7e329ec...6316cf9. Read the comment docs.

johnnychen94 commented 5 years ago

ping @zygmuntszpak

zygmuntszpak commented 5 years ago

Thanks!