search

JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
136 stars 32 forks source link

Added kwarg handler to imshow for custom clims #229

Closed sremedios closed 4 years ago

sremedios commented 4 years ago

Added kwhandler to one instance of imshow to handle custom CLims alongside axes specifications.

timholy commented 4 years ago

This message is redeemable for one free comment-out-that-failing-precompile-statement in your PR (I will come back later and fix it myself, it's not entirely straightforward to get them right). I put them inside an assert so I know if they've gone stale; it's served that purpose, and I don't want it to get in your way with regards to your kind contribution here.

To ensure we don't regress, Ideally a test would be good, perhaps you could just use a version of the things that failed in #228.

timholy commented 4 years ago

I'll merge this despite all the tests failing (click the "Details" about the failure to see why). The remedy is to comment out the failing precompile statement, as indicated in https://github.com/JuliaImages/ImageView.jl/pull/229#issuecomment-707232447, but I'll just do that locally.

Thanks for the contribution!