search

JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
136 stars 32 forks source link

CompatHelper: bump compat for Images to 0.24, (keep existing compat) #249

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the Images package from 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23 to 0.15, 0.16, 0.17, 0.18, 0.19, 0.20, 0.21, 0.22, 0.23, 0.24. This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

timholy commented 3 years ago

Anyone know why the tests didn't run?

johnnychen94 commented 3 years ago

It might be due to my recent personal ssh-key cleanup. Just updated a new pair of ssh keys and let me retrigger the CompatHelper and see if it works.

Update: indeed it is my fault. #250

johnnychen94 commented 3 years ago

The current latest Images version is not yet compatible to ImageCore@0.9. Is it possible to use ImageCore or ImageBase here?

timholy commented 3 years ago

I have a local branch that switches to GtkObservables but I don't think I've switched to a lower-demand Images deps yet. Definitely want to do that.

timholy commented 3 years ago

But it's held up by the segfaults, see e.g., https://github.com/JuliaGizmos/GtkObservables.jl/actions/runs/1044835147