JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
136 stars 32 forks source link

Switch to test/Project.toml #260

Closed IanButterworth closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #260 (b61eeff) into master (23c3808) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #260   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files           7        7           
  Lines         944      944           
=======================================
  Hits          632      632           
  Misses        312      312           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23c3808...b61eeff. Read the comment docs.

timholy commented 2 years ago

What's the advantage? I can't find it now, but a recent conversation I only skimmed between Shuhei & @KristofferC suggested little advantage (which has been my experience).

IanButterworth commented 2 years ago

Well, this was prompted because when I did

pkg> test ImageView

sometime during test execution it complained about some of the test deps not being installed. I think ones that FileIO used indirectly, QuartzImageIO etc.

This format doesn't do that and installed everything upfront.

Maybe that's a Pkg bug though

timholy commented 2 years ago

Hmm, interesting. I don't see why they'd be different, but I haven't dug into it.

IanButterworth commented 2 years ago

Me neither. I'll try to come up with a MWE for Pkg

KristofferC commented 2 years ago

sometime during test execution it complained about some of the test deps not being installed

That sounds weird.. Would be good to track that down indeed.

IanButterworth commented 1 year ago

Closing as stale