search

JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
135 stars 34 forks source link

Stop pirating `scaleminmax` #269

Closed timholy closed 2 years ago

timholy commented 2 years ago

scaleminmax is owned by ImageCore and the colors it operates on are owned by ColorTypes. In contrast to both Colors and ColorVectorspace, for which piracy is their raison d'etre, this is not really a sanctioned case of piracy.

We could add these methods to ImageCore, but I think they'd be a little dicey, so best to make them internal.

timholy commented 2 years ago

Hah, a typo revealed that test/core.jl wasn't even being run

codecov[bot] commented 2 years ago

Codecov Report

Merging #269 (bbbdf51) into master (ca4bb57) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #269      +/-   ##
==========================================
+ Coverage   83.54%   83.56%   +0.02%     
==========================================
  Files           6        6              
  Lines         778      779       +1     
==========================================
+ Hits          650      651       +1     
  Misses        128      128
Impacted Files Coverage Δ
src/ImageView.jl 88.66% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca4bb57...bbbdf51. Read the comment docs.