JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
135 stars 34 forks source link

Gtk4 port #284

Closed jwahlstrand closed 11 months ago

jwahlstrand commented 1 year ago

I think this is ready to be tried out. Tests pass for me.

jwahlstrand commented 1 year ago

Argh, sorry for triggering CI again -- I meant to add a [skip ci] to prevent that. I guess it's freezing because it's using the registered version of GtkObservables, which depends on Gtk (?)

I've made some progress on the port of GtkObservables -- scroll-zoom now works. The missing piece is simulating mouse events with keyboard modifiers, which we need for testing and precompiling. I may need to add GdkEvent support to Gtk4.

timholy commented 1 year ago

No worries. If there's any way that commit privileges here and in GtkObservables would help your work, just ask and it will be granted.

jwahlstrand commented 1 year ago

If there's any way that commit privileges here and in GtkObservables would help your work, just ask and it will be granted.

I'll take you up on that for GtkObservables. I'd like to run the CI tests for all platforms. It's working well for me locally now.

codecov[bot] commented 12 months ago

Codecov Report

Patch coverage: 97.61% and project coverage change: +0.03% :tada:

Comparison is base (0087262) 84.72% compared to head (53774fa) 84.76%. Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #284 +/- ## ========================================== + Coverage 84.72% 84.76% +0.03% ========================================== Files 6 6 Lines 838 840 +2 ========================================== + Hits 710 712 +2 Misses 128 128 ``` | [Files Changed](https://app.codecov.io/gh/JuliaImages/ImageView.jl/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages) | Coverage Δ | | |---|---|---| | [src/link.jl](https://app.codecov.io/gh/JuliaImages/ImageView.jl/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL2xpbmsuamw=) | `100.00% <ø> (ø)` | | | [src/ImageView.jl](https://app.codecov.io/gh/JuliaImages/ImageView.jl/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL0ltYWdlVmlldy5qbA==) | `89.79% <96.42%> (+0.08%)` | :arrow_up: | | [src/annotations.jl](https://app.codecov.io/gh/JuliaImages/ImageView.jl/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL2Fubm90YXRpb25zLmps) | `75.34% <100.00%> (ø)` | | | [src/contrast\_gui.jl](https://app.codecov.io/gh/JuliaImages/ImageView.jl/pull/284?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaImages#diff-c3JjL2NvbnRyYXN0X2d1aS5qbA==) | `86.76% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jwahlstrand commented 11 months ago

All tests now pass, including the ones that were commented out before. I am going through the README and trying everything to make sure things work as advertised. I'm seeing a few things I want to fix before this is merged.

timholy commented 11 months ago

I took a brief look and everything seems uncontroversial. You can merge whenever you feel comfortable. Many thanks, I've been moving my lab and its so kind for you to carry this forward!

jwahlstrand commented 11 months ago

Great, thanks! One pesky issue remains -- when you zoom in on the pointer (control-scroll), it doesn't stay centered on the pointer. It zooms in and out and stays in the same general region as the pointer, but it's not as nice as before, and I haven't figured out why. I will give it another try this weekend, but if I can't fix it I may just merge and we can figure it out later. I generally have more time on weekends for Julia BTW.

As someone who moved my lab a few years ago, I feel your pain!

jwahlstrand commented 11 months ago

I did fix the zooming bug I mentioned, which was in GtkObservables.

ashwani-rathee commented 10 months ago

Amazing Job @jwahlstrand!!, Can you please make the new release?

jwahlstrand commented 10 months ago

Sure, 0.12.0 I guess? I'll have time to do it tomorrow morning.

ashwani-rathee commented 10 months ago

Yep, 0.12.0 would work