search

JuliaImages / ImageView.jl

Interactive display of images and movies
MIT License
135 stars 34 forks source link

contrast GUI: convert new minimum and maximum values to float #311

Closed jwahlstrand closed 2 months ago

jwahlstrand commented 2 months ago

Implements suggestion from @kimikage

Fixes #310

I verified that this still avoids the crash in #308

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.74%. Comparing base (27fb192) to head (6f632bd).

:exclamation: Current head 6f632bd differs from pull request most recent head ca4de2b

Please upload reports for the commit ca4de2b to get more accurate results.

Files Patch % Lines
src/contrast_gui.jl 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #311 +/- ## ========================================== + Coverage 85.01% 85.74% +0.73% ========================================== Files 6 6 Lines 814 870 +56 ========================================== + Hits 692 746 +54 - Misses 122 124 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kimikage commented 2 months ago

I have once again checked the implementation of the contrast GUI and noticed several design issues. However, I think it is a good idea to release this first as a quick fix.

jwahlstrand commented 2 months ago

Thanks. The code does somehow seem a bit complicated for what it does. I'll merge this now and do another release.